-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert migration to FML messageloops on Fuchsia #15903
Conversation
…fml::{Thread,MessageLoop} (flutter#15118)" This reverts commit a50f1ef.
This pull request is not suitable for automatic merging in its current state.
|
@gw280 some tests might need to be disabled? |
Looks like this test is failing on master too. I'm going to manually merge to unblock Fuchsia as this PR isn't the cause. I think the latest Dart roll broke a text test https://github.com/flutter/engine/runs/404318234 |
Filed flutter/flutter#49331 for the failing test |
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter/engine#15903)
flutter/engine@46e58b9...439a218 git log 46e58b9..439a218 --first-parent --oneline 2020-01-23 zhongwuzw@qq.com Fixes labelPrefix memory leak in FlutterEngine (flutter/engine#14674) 2020-01-23 matthew-carroll@users.noreply.github.com Release TextureView surface within FlutterTextureView when disconnected. (#48535) (flutter/engine#15899) 2020-01-23 iska.kaushik@gmail.com [fuchsia] Timeline events in profile mode to observatory (flutter/engine#15900) 2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from N502w... to Wc7e4... (flutter/engine#15935) 2020-01-23 tvolkert@users.noreply.github.com Add script to force build LUCI builders for a specified commit (flutter/engine#15938) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) (flutter/engine#15934) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia f9aea7f7e502..e4ddb8a7cddc (35 commits) (flutter/engine#15931) 2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from LGwl3... to LAOYs... (flutter/engine#15930) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 582727a4ec3b..6aa7407d6309 (4 commits) (flutter/engine#15923) 2020-01-23 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#15903) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart a9ea9365ad8a..582727a4ec3b (33 commits) (flutter/engine#15906) 2020-01-22 brianosman@google.com Implement new SkCanvas virtuals in testing canvases (flutter/engine#15893) 2020-01-22 dnfield@google.com Const finder fixes (flutter/engine#15880) 2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v-OJE... to N502w... (flutter/engine#15892) 2020-01-22 dnfield@google.com errant log (flutter/engine#15891) 2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia d59053987a27..f9aea7f7e502 (10 commits) (flutter/engine#15890) 2020-01-22 jason-simmons@users.noreply.github.com [libtxt] Assign a unique ID to each glyph cluster within a line (flutter/engine#15742) 2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/dart 439cabaec02f..a9ea9365ad8a (4 commits) (flutter/engine#15886) 2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jAkm1... to LGwl3... (flutter/engine#15884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
…fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903) This reverts commit a50f1ef.
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit a37eb4c.
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.
…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.
This caused a chaselist issue on Fuchsia. We know a likely fix, but as this is a chaselist, revert first then fix.